[C#] Fixed ArgumentOutOfRangeException. Optimized string concatenation. #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the list is empty you get the ArgumentOutOfRangeException when calling flattenString.Remove(flattenString.Length - 1). Also using a StringBuilder is the prefered way to concatenate strings in a loop.
artem-dudarev
changed the title
|
@artem-dudarev thanks for the PR. The change looks good to me. Will merge it shortly. |
wing328
added a commit
that referenced
this pull request
Dec 15, 2015
[C#] Fixed ArgumentOutOfRangeException. Optimized string concatenation.
|
Next time please update the Petstore sample as mentioned in https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the list is empty you get the
ArgumentOutOfRangeExceptionwhen callingflattenString.Remove(flattenString.Length - 1)because it tries to remove a separator from the empty string.Also using a
StringBuilderis the prefered way to concatenate strings in a loop.