Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to TypeScript Templates #1383

Closed
wants to merge 2 commits into from
Closed

Conversation

aersam
Copy link
Contributor

@aersam aersam commented Oct 13, 2015

Resolves #1334 . If it needs some improvements, please give me feedback

@wing328
Copy link
Contributor

wing328 commented Oct 13, 2015

@aersamkull thanks for the PR. The CI build failure is likely caused by other swagger components (e.g. swagger-parser) that we're looking into at the moment.

I wonder if you can also run ./bin/typescript-angular-petstore.sh and ./bin/typescript-node-petstore.sh to update the Petstore code sample. Then please follow the readme in sample directory to run the unit testing for TypeScript (AngularJS, NodeJS) Petstore.

@aersam
Copy link
Contributor Author

aersam commented Oct 13, 2015

Now I did, however I am getting noImplicitAny errors. I don't think I did change something there. Has this happened before?

@wing328
Copy link
Contributor

wing328 commented Oct 13, 2015

Last time I ran it, the test passed but it was a while ago.

To confirm, can you please pull the latest master and run the test under the sample folder for typescript to see if you get the same error?

@aersam
Copy link
Contributor Author

aersam commented Oct 13, 2015

Yes, the error already existed. But it is trivial to fix. Just have to change line 18 of api.mustache in TypeScript-Angular:

constructor(private $http: ng.IHttpService, basePath?: string, private $httpParamSerializer?: (d: any) => any) {

The important thing is to change $httpParamSerializer?: (any) => any to $httpParamSerializer?: (d: any) => any

@wing328
Copy link
Contributor

wing328 commented Oct 13, 2015

@aersamkull thanks for identifying the issue and including the fix in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants