Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new language: UE4 C++ client #10260

Merged
merged 3 commits into from
May 26, 2020
Merged

Conversation

Kahncode
Copy link
Contributor

@Kahncode Kahncode commented May 19, 2020

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Added a client generator for Unreal Engine 4 C++ framework.
During that process I noticed a lot of issues with the abstract cpp generator as well as the existing c++ generators (qt5 and cpprest). Some of these issues are currently fixed within the UE4 generator, but could be easily moved to the base classes. In this PR i focused on making the UE4 generator work with the least possible changes to the codebase. If required, I could move some of my improvements to affect other CPP generators.
Notes:

  • I have not been able to run tests locally, I'm very unfamiliar with maven and could not manage to make it work fully.
  • I may have also let slip some Java no-nos, again this is a language I do not usually program in, and I welcome every bit of feedback for this.
  • I tested the UE4 generator with Petstore and some real-life complex use-cases for my professional project.
  • This generator should support more things than the existing C++ generators as far as I can see, most notably it supports enumerations properly.

@Kahncode Kahncode marked this pull request as ready for review May 19, 2020 13:24
@Kahncode Kahncode closed this May 26, 2020
@Kahncode Kahncode reopened this May 26, 2020
@HugoMario
Copy link
Contributor

hey @Kahncode let me know once it's ready for merging

@HugoMario HugoMario merged commit 5abc6ad into swagger-api:master May 26, 2020
@HugoMario
Copy link
Contributor

thanks a lot!

@Kahncode Kahncode mentioned this pull request May 26, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants