Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of proxy.changeOrigin to true #66

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feat

  • What is the related issue? (Use #issue_id to relate an open issue)

no

  • Does this PR introduce a breaking change?

Yes, we found that CORS is needed in most development cases, so we changed the default value of proxy.changeOrigin to true now.

  • Other information:

@xuchaoying xuchaoying marked this pull request as ready for review August 26, 2019 03:59
@xuchaoying xuchaoying added the PR: new feature :rocket: New Feature label Aug 26, 2019
@xuchaoying xuchaoying self-assigned this Aug 26, 2019
@xuchaoying xuchaoying added PR: breaking change :boom: Breaking Change and removed PR: new feature :rocket: New Feature labels Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          44       44           
  Lines        1561     1561           
=======================================
  Hits         1409     1409           
  Misses        152      152
Impacted Files Coverage Δ
...ackages/svrx/lib/plugin/svrx-plugin-proxy/index.js 64.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0999450...10f98cf. Read the comment docs.

@xuchaoying xuchaoying merged commit 627db59 into master Aug 26, 2019
@xuchaoying xuchaoying deleted the cy-changeorigin branch August 26, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change :boom: Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants