Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the priority of cors and route #173

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Fix the priority of cors and route #173

merged 2 commits into from
Dec 24, 2019

Conversation

xuchaoying
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests is needed?
    • Tests for the changes have been added
  • Docs is needed?
    • Docs have been added / updated

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Enhencement
  • Refactor
  • Documents
  • Others
  1. Priority of cors should be higher than that of route. Add priorioty 300 to plugin cors

What is the related issue?

#172

Does this PR introduce a breaking change?

  • breaking change?

Other information:

@xuchaoying xuchaoying requested a review from leeluolee December 23, 2019 08:36
@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Dec 23, 2019
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #173 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #173      +/-   ##
=========================================
+ Coverage    95.7%   95.7%   +<.01%     
=========================================
  Files          49      49              
  Lines        1675    1676       +1     
=========================================
+ Hits         1603    1604       +1     
  Misses         72      72
Impacted Files Coverage Δ
packages/svrx/lib/constant.js 100% <ø> (ø) ⬆️
packages/svrx/lib/plugin/svrx-plugin-cors/index.js 87.5% <100%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ac5ac...89010d0. Read the comment docs.

@xuchaoying xuchaoying merged commit 68dd767 into master Dec 24, 2019
@xuchaoying xuchaoying deleted the cy-route-cors branch December 24, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants