Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support svrx-plugin-ui #168

Merged
merged 16 commits into from
Dec 24, 2019
Merged

Support svrx-plugin-ui #168

merged 16 commits into from
Dec 24, 2019

Conversation

xuchaoying
Copy link
Member

@xuchaoying xuchaoying commented Dec 6, 2019

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests is needed?
    • Tests for the changes have been added
  • Docs is needed?
    • Docs have been added / updated

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Enhencement
  • Refactor
  • Documents
  • Others
  1. Add some internal methods for ui
  2. Refactor some builtin config schema
  3. Support hotreload for some builtin configs
    1. Support plugin reload

What is the related issue?

Does this PR introduce a breaking change?

  • breaking change?

Other information:

@xuchaoying xuchaoying added the PR: new feature :rocket: New Feature label Dec 6, 2019
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #168 into master will increase coverage by 0.26%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage    95.7%   95.97%   +0.26%     
==========================================
  Files          49       50       +1     
  Lines        1676     1688      +12     
==========================================
+ Hits         1604     1620      +16     
+ Misses         72       68       -4
Impacted Files Coverage Δ
packages/svrx/lib/config-list.js 100% <ø> (ø) ⬆️
packages/svrx/lib/constant.js 100% <ø> (ø) ⬆️
...ackages/svrx/lib/plugin/svrx-plugin-serve/index.js 97.36% <100%> (+10.41%) ⬆️
packages/svrx/lib/configure/plugin.js 100% <100%> (ø) ⬆️
packages/svrx/lib/plugin/system.js 90.82% <100%> (ø) ⬆️
packages/svrx/lib/configure/index.js 98.78% <100%> (+0.03%) ⬆️
packages/svrx/lib/svrx.js 95.28% <100%> (+0.18%) ⬆️
...b/plugin/svrx-plugin-history-api-fallback/index.js 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c865de...49938ee. Read the comment docs.

@xuchaoying xuchaoying marked this pull request as ready for review December 20, 2019 07:30
@xuchaoying xuchaoying requested a review from a team December 23, 2019 08:37
leeluolee
leeluolee previously approved these changes Dec 24, 2019
@xuchaoying xuchaoying merged commit 6846a6c into master Dec 24, 2019
@xuchaoying xuchaoying deleted the cy-ui branch December 24, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: new feature :rocket: New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants