Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert global-npm to 0.3.0 #165

Merged
merged 3 commits into from
Dec 2, 2019
Merged

fix: revert global-npm to 0.3.0 #165

merged 3 commits into from
Dec 2, 2019

Conversation

xuchaoying
Copy link
Member

@xuchaoying xuchaoying commented Dec 2, 2019

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests is needed?
    • Tests for the changes have been added
  • Docs is needed?
    • Docs have been added / updated

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Enhencement
  • Refactor
  • Documents
  • Others
  1. revert global-npm back to 0.3.0 to fix the problem that cannot find 'npm' when start svrx core from npm scripts.

What is the related issue?

Does this PR introduce a breaking change?

  • breaking change?

Other information:

fix can't find 'npm' error in some cases
@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #165   +/-   ##
======================================
  Coverage    95.7%   95.7%           
======================================
  Files          49      49           
  Lines        1675    1675           
======================================
  Hits         1603    1603           
  Misses         72      72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1e46a...58af5fe. Read the comment docs.

@xuchaoying xuchaoying requested a review from a team December 2, 2019 07:56
@xuchaoying xuchaoying merged commit 6c68d24 into master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants