Replace global-npm.install with npminstall #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent other plugin auto deletion when install a new one
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 92.34% 92.37% +0.03%
==========================================
Files 44 45 +1
Lines 1607 1614 +7
==========================================
+ Hits 1484 1491 +7
Misses 123 123
Continue to review full report at Codecov.
|
leeluolee
reviewed
Nov 7, 2019
|
Please merge quickly. |
leeluolee
approved these changes
Nov 8, 2019
xuchaoying
added a commit
that referenced
this pull request
Nov 14, 2019
This reverts commit cb1f791
xuchaoying
added a commit
that referenced
this pull request
Nov 18, 2019
* Revert "fix: replace global-npm.install with npminstall (#148)" This reverts commit cb1f791 * build: add package-manager test for plugins * build: add other package-manager test for plugins * feat(util): add package-manager for plugins * refactor: move name formatter to util package * refactor(util): remove package-manager localinstall * refactor(util): change return value.name to pluginName instead of packageName * refactor(plugin): replace plugin load with package-manager * fix(package-manager): fix dependencies install * test(package-manager): fix getRemoteBestfit * refactor: remove package installation in core * refactor(package-manager): add view task * feat(package-manager): add auto download latest packages before load * test: add timeout * build(deps): update deps * refactor: simplify packName definition * refactor: remove core package manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent other plugin auto deletion when install a new one
bug fix
#issue_idto relate an open issue)#142
no