Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix windows path parse error #145

Merged
merged 4 commits into from
Nov 1, 2019
Merged

Conversation

int64ago
Copy link
Member

@int64ago int64ago commented Nov 1, 2019

  • Please check if the PR fulfills these requirements
  • [ x ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

webwxgetmsgimg

  • What is the related issue? (Use #issue_id to relate an open issue)

#144

  • Does this PR introduce a breaking change?

No

  • Other information:

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #145 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   92.34%   92.34%   +<.01%     
==========================================
  Files          44       44              
  Lines        1606     1607       +1     
==========================================
+ Hits         1483     1484       +1     
  Misses        123      123
Impacted Files Coverage Δ
packages/svrx/lib/router/loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e35ff...b49c5d4. Read the comment docs.

leeluolee
leeluolee previously approved these changes Nov 1, 2019
@leeluolee leeluolee added this to the v1.0.6 milestone Nov 1, 2019
@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Nov 1, 2019
@xuchaoying xuchaoying merged commit fedf7a0 into master Nov 1, 2019
@xuchaoying xuchaoying deleted the hotfix/windows_route_load_fail branch November 1, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants