Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not working on Windows #135

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Fix not working on Windows #135

merged 2 commits into from
Oct 28, 2019

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug fix

  • What is the related issue? (Use #issue_id to relate an open issue)

#128

  • Does this PR introduce a breaking change?

no

  • Other information:

@svrx/util is updated in this PR, so @svrx/cli need to be updated too

@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Oct 28, 2019
@xuchaoying xuchaoying requested a review from a team October 28, 2019 07:13
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #135 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   92.33%   92.34%   +<.01%     
==========================================
  Files          44       44              
  Lines        1604     1606       +2     
==========================================
+ Hits         1481     1483       +2     
  Misses        123      123
Impacted Files Coverage Δ
packages/svrx/lib/configure/index.js 98.75% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8816e18...d8f75a9. Read the comment docs.

@xuchaoying xuchaoying merged commit c5185c7 into master Oct 28, 2019
@xuchaoying xuchaoying deleted the cy-fix-windows branch October 28, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants