Test regressions with W3C SVG 1.1 Test Suite #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this run on CI? If so, perhaps a separate job? |
|
Yes, it will be. Not all tests are passing yet. This is why it's draft. |
3 tasks
|
Great work @TrySound. I was working on something similar too. I'm using:
See screenshots attached:
Maybe we should create an issue where we can discuss ideas. |
|
Sure, feel free to open one |
TrySound
added a commit
that referenced
this pull request
Feb 23, 2021
Ref https://github.com/svg/sax/releases/tag/v0.1.1 This fixes enother case in [regression tests](#1357).
TrySound
added a commit
that referenced
this pull request
Feb 23, 2021
Ref https://github.com/svg/sax/releases/tag/v0.1.1 This fixes enother case in [regression tests](#1357).
TrySound
force-pushed
the
test-regression
branch
from
965d6ee to
3b75607
Compare
TrySound
force-pushed
the
test-regression
branch
3 times, most recently
from
a08b452 to
45d664d
Compare
Visual regressions tests will give us more confidence in SVGO stability. Test cases are downloaded from w3.org, screenshooted with playwright and compared with pixelmatch.
TrySound
force-pushed
the
test-regression
branch
from
45d664d to
11cfb52
Compare
|
Current result |
This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual regressions tests will give us more confidence in SVGO stability.
Test cases are downloaded from w3.org, screenshooted with playwright and
compared with pixelmatch.
See test suite https://www.w3.org/Graphics/SVG/Test/20110816/
Bugs detected with these tests: