convertStyleToAttrs: fix wrong character class #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to cover it with test case |
|
Or nevermind. Eslint may cover it too. |
|
I'd add CodeQL or LGTM itself; unsure if ESLint detects it yet. BTW I was planning to make a PR to add xo for linting. Do you have any preference regarding indentation etc? |
|
I'll add eslint myself. Prefer it to it to not force formatting. Will add prettier after dealing with pull requests. |
|
@TrySound could you please finish with the remaining style/linting tweaks? I'd like to take a closer look at some things and right now things are inconsistent. |
This was referenced May 22, 2021
chore(deps): update dependency svgo to v2 - autoclosed
fisker/serve-directory-theme-city-lights#1346
Closed
This was referenced Jun 6, 2021
This was referenced Jun 30, 2021
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was flagged by lgtm