Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove comments from each block with animate #7146

Closed
wants to merge 2 commits into from
Closed

[fix] Remove comments from each block with animate #7146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2f8ca8
strip comments
ghostdevv Jan 15, 2022
e580983
test for comment stripping
ghostdevv Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/compile/nodes/EachBlock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default class EachBlock extends AbstractBlock {
([this.const_tags, this.children] = get_const_tags(info.children, component, this, this));

if (this.has_animation) {
this.children = this.children.filter(child => !isEmptyNode(child));
this.children = this.children.filter(child => !(child.type == 'Comment' || isEmptyNode(child)));

if (this.children.length !== 1) {
const child = this.children.find(child => !!(child as Element).animation);
Expand Down
1 change: 1 addition & 0 deletions test/validator/samples/animation-each-with-comment/errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
11 changes: 11 additions & 0 deletions test/validator/samples/animation-each-with-comment/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<script>
function flip() {}
</script>

<div>
{#each [] as n (n)}
<!-- Comment -->
<!-- <div animate:flip></div> -->
<div animate:flip />
{/each}
</div>