fix: global with pseudo element should be considered as global

[roychoo]

Hi,
in PR, https://github.com/sveltejs/svelte/pull/6223/files#diff-145a1fa56c966be609d17f4af6eb9c2a0a97cd2f1c9c86bf64841595f254f51dR597, an additional check was introduced to make sure the number of selectors is equal to 1, however this also covers pseudo elements which in turn break some of the existing capabilities as describe in #6306

 .container :global(section) > :global(*):first-child {
	color: red;
}

global(*):first-child is no longer considered as a global where previously it was considered.

Thus, adding a negation check that if there is a ClassSelector, it should be excluded from global check.

cc: @tanhauhau (PR #6223 author)

[alcore]

We've had to pin to 3.37 for now, due to the issue this PR attempts to solve, as #6223 broke syntax that was previously valid using preprocessors' nesting. Before 3.38 this compiled fine (SASS):

div
  :global(p)
    &:after, &:before
      color: red

Where div had the component's hashed class applied and any :global child had its styles applied correctly too - this is not currently the case, and they are not applied at all, silently.

I.e. unlike with nesting ... :global(...) :global(...) which throws an error (where it was legal previously), pseudoclasses get dropped and result in a silently broken stylesheet compilation for anyone utilizing this pattern.

[7antra]

It will be interesting to merge this PR soon, because now in the 1.0.0-next.106 of @svelte/kit the minimum version accepted for svelte (peerDependencies) is 3.38.2

[roychoo]

Hi, since it had been some time, is there any feedback on this proposed fix in this PR?

[7antra]

@roychoo Do you know how to speed up the merging process of this PR? Because for all developers who use svelte + scss this ":global()" bug is very annoying and prevents the update :'(

[roychoo]

@roychoo Do you know how to speed up the merging process of this PR? Because for all developers who use svelte + scss this ":global()" bug is very annoying and prevents the update :'(

I am not sure myself, this is my first time contributing to svelte

[non25]

Shameless plug: sveltejs/rfcs#13 (comment)

[roychoo]

Thanks for the adjustment and merged

[7antra]

Thank you @Conduitry <3