Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use periscopic #3785

Merged
merged 5 commits into from
Nov 6, 2019
Merged

Conversation

tanhauhau
Copy link
Member

Depend on Rich-Harris/periscopic#2

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Rich-Harris
Copy link
Member

This is great. I've upgrade periscopic on this branch, but I'm getting some weird test failures that I haven't figured out yet

@tanhauhau
Copy link
Member Author

found some discrepancy with the original scope behavior and the one in periscopic: Rich-Harris/periscopic#4

@tanhauhau tanhauhau force-pushed the tanhauhau/use-periscopic branch from 24da1cd to bad7443 Compare October 30, 2019 14:31
@tanhauhau
Copy link
Member Author

Oh no errors again? :'(

@tanhauhau
Copy link
Member Author

Hmm there's some issues with component names?

@Rich-Harris
Copy link
Member

Huh. Wonder if that's related to #3846

@Rich-Harris Rich-Harris merged commit b3de6be into sveltejs:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants