Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set data- attributes like regular attributes #3346

Merged
merged 1 commit into from
Aug 3, 2019
Merged

set data- attributes like regular attributes #3346

merged 1 commit into from
Aug 3, 2019

Conversation

Conduitry
Copy link
Member

Fixes #3337. No specific runtime tests, as this doesn't seem like something that is likely to break again, and also there are already relevant js sample tests.

@Rich-Harris Rich-Harris merged commit 64094f6 into sveltejs:master Aug 3, 2019
@Rich-Harris
Copy link
Member

I renamed the do-use-dataset test, since it's a bit misleading now, and removed the (now identical) other data-foo tests

@Conduitry Conduitry deleted the gh-3337 branch August 3, 2019 19:02
@Conduitry
Copy link
Member Author

Whoops, didn't even know those were there, good catch

@cvlab cvlab mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dataset optimization does not respect null indicating to remove the attribute
2 participants
@Conduitry @Rich-Harris