Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove internal gubbins when using bind:props #2083

Merged
merged 1 commit into from
Feb 17, 2019
Merged

remove internal gubbins when using bind:props #2083

merged 1 commit into from
Feb 17, 2019

Conversation

Rich-Harris
Copy link
Member

fixes #2038. Slightly inelegant perhaps, but a tidier option would mean not using props for internal stuff, which would be a much more comprehensive set of changes.

@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #2083 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2083   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines          49      49           
======================================
  Hits           49      49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61616e...a50c84e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal variables showing up in svelte:options bind:props
2 participants