Skip to content

fix: improve error message for migration errors when slot would be renamed #15841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

lfrancke
Copy link
Contributor

The warning would just say

This migration would change the name of a slot making the component unusable

Now it says

This migration would change the name of a slot (derived to derived_1) making the component unusable

I'm totally open to changing the message itself.
For me, as a newbie, it was really unhelpful to not have any context so I included the name of the "bad" slot here.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

…ng conflicts now states the name of the slot causing the issue
Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: 895b9a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paoloricciuti paoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🧡

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15841

@paoloricciuti paoloricciuti changed the title feat: The migration warning when slots cannot be migrated due to naming conflicts now states the name of the slot causing the issue fix: improve error message for migration errors when slot would be renamed Apr 30, 2025
@paoloricciuti paoloricciuti merged commit c051a6e into sveltejs:main Apr 30, 2025
9 checks passed
@lfrancke lfrancke deleted the feat/migration-script-message branch April 30, 2025 06:54
@github-actions github-actions bot mentioned this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants