Using pageYOffset & pageXOffset

[arxpoetica]

Okay, feeling a little apprehensive about this one. Discussion about this over here: https://gitter.im/sveltejs/svelte?at=5a859561d74ee9f50dcac27b

Normally I'd try to push up something more complete, but I need to just get my feet wet to learn; trial and error. I wanted to push this up to get eyes on it so I could learn through that process. Thanks for being patient with me.

Right now there's one failing test which I think actually makes sense <<js window-binding-scroll>>, but I need to dig into it a little more.

See: #1175

[Rich-Harris]

thank you! Is there any reason to keep scrollX and scrollY (internally I mean, we should definitely keep bind:scrollX and bind:scrollY)? There doesn't seem to be any downside to replacing window.pageXOffset || window.scrollX with window.pageXOffset everywhere (since pageXOffset is usually zero, using both just means doing two property lookups instead of one in most cases).

[arxpoetica]

According to MDN there's no reason—that's just my conservative caution. ;) Happy to just do the one if you think it's better.

[arxpoetica]

Also, when you have a chance, can you spot check my changes? I don't know the code base well enough to know if I've touched anything that I shouldn't have.

[Rich-Harris]

the changes are all 💯 — though yeah, I think we should just use pageXOffset and pageYOffset

[Rich-Harris]

btw i think that one failing test relates to this block: https://github.com/sveltejs/svelte/blob/master/src/generators/nodes/Window.ts#L103-L105

[codecov-io]

Codecov Report

Merging #1176 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   91.63%   91.63%   +<.01%     
==========================================
  Files         127      127              
  Lines        4565     4567       +2     
  Branches     1502     1503       +1     
==========================================
+ Hits         4183     4185       +2     
  Misses        160      160              
  Partials      222      222

Impacted Files	Coverage Δ
src/generators/nodes/Window.ts	80.28% <66.66%> (+0.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0648998...e95a0b6. Read the comment docs.