remove <noscript> elements in DOM mode (#1108) #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
+ Coverage 91.51% 91.78% +0.26%
==========================================
Files 126 126
Lines 4526 4624 +98
Branches 1462 1508 +46
==========================================
+ Hits 4142 4244 +102
- Misses 163 165 +2
+ Partials 221 215 -6
Continue to review full report at Codecov.
|
|
nice — opened an issue on the docs repo. Maybe we just need a 'miscellaneous' section at the end for odds and sods like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1108 - but we probably should still document this behavior somewhere. Not sure where in the guide is the best place to do that.