Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable two-way binding #1059

Merged
merged 3 commits into from
Dec 30, 2017
Merged

add option to disable two-way binding #1059

merged 3 commits into from
Dec 30, 2017

Conversation

Rich-Harris
Copy link
Member

Alternative to #1056. Fixes #54

@codecov-io
Copy link

codecov-io commented Dec 30, 2017

Codecov Report

Merging #1059 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   92.02%   92.04%   +0.02%     
==========================================
  Files         121      121              
  Lines        4376     4538     +162     
  Branches     1410     1506      +96     
==========================================
+ Hits         4027     4177     +150     
- Misses        148      152       +4     
- Partials      201      209       +8
Impacted Files Coverage Δ
test/parser/index.js 100% <ø> (ø) ⬆️
src/parse/state/tag.ts 96.07% <100%> (+0.05%) ⬆️
src/parse/index.ts 89.28% <100%> (+0.12%) ⬆️
src/validate/html/validateElement.ts 87.58% <0%> (-1.31%) ⬇️
src/generators/nodes/Text.ts 100% <0%> (ø) ⬆️
src/generators/dom/index.ts 96.42% <0%> (+1%) ⬆️
src/validate/index.ts 88.88% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5dba9...f5aebae. Read the comment docs.

@Conduitry
Copy link
Member

I'd been trying to organize the options in the readme into roughly conceptual sections. I think bind more belongs in the first section, which contains options to alter the behavior of the component or features in the compiled component.

@Rich-Harris
Copy link
Member Author

Totally missed that! Updated

@Rich-Harris Rich-Harris merged commit 3a9b3ea into master Dec 30, 2017
@Rich-Harris Rich-Harris deleted the gh-54 branch December 30, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants