Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler error: this shouldn't happen! generated code is trying to use inexistent internal #3173

Closed
btakita opened this issue Jul 4, 2019 · 6 comments · Fixed by #3186
Closed

compiler error: this shouldn't happen! generated code is trying to use inexistent internal #3173

btakita opened this issue Jul 4, 2019 · 6 comments · Fixed by #3186
Labels
bug

Comments

@btakita
Copy link
Contributor

btakita commented Jul 4, 2019

This occurs with an A component that takes a href property that contains "mailto:".

https://svelte.dev/repl/90d5d66d0ad64c0397129a035cd906a5?version=3.6.4
@btk5h
Copy link
Contributor

btk5h commented Jul 4, 2019 •
edited
Loading

Another repro.

This happens with any component (not element) with children and a prop containing an @ symbol not followed by an internal compiler method.

@Conduitry Conduitry added the bug label Jul 4, 2019
@mrkishi
Copy link
Member

mrkishi commented Jul 4, 2019

Yikes, sorry about that. That was me on #2963, although it is catching a compiler bug. PR incoming.

@Conduitry
Copy link
Member

Similar to #3114. It looks like this one is because of the // (5:0) <Component anyProp="@contains_at_symbol"> comment not having the @ symbol escaped. (This does mean that, prior to 3.6.0, we were dropping a @ from any such comment - REPL - which is also a bug, but a much less serious one.) It's interesting that this comment is only generated when the component has slotted child content being passed into it - this is why the error only appears in that case.

Conduitry added a commit to Conduitry/sveltejs_svelte that referenced this issue Jul 5, 2019
@Conduitry
escape @ sigils in debug comments (sveltejs#3173)
398c3ef
@Conduitry Conduitry mentioned this issue Jul 5, 2019
Merged
Conduitry added a commit to Conduitry/sveltejs_svelte that referenced this issue Jul 5, 2019
@Conduitry
escape @ sigils in block comments (sveltejs#3173)
2d9041f
@btakita
Copy link
Contributor Author

btakita commented Jul 6, 2019

: also needs to be escaped.

@Conduitry
Copy link
Member

Where does : need to be escaped? What component is either failing to compile or producing incorrect output?

Rich-Harris added a commit that referenced this issue Jul 6, 2019
@Rich-Harris
Merge pull request #3186 from Conduitry/gh-3173
6adf7b3 
escape `@` sigils in block comments
@btakita
Copy link
Contributor Author

btakita commented Jul 7, 2019

You're right. I thought mailto: caused an issue, but didn't check in the repl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

escape @ sigils in block comments Conduitry/sveltejs_svelte
4 participants
@btakita @mrkishi @btk5h @Conduitry