-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From 3.6.0: "TypeError: Cannot read property 'block' of null" #3113
Comments
I can confirm this. Downgrading to 3.5.4 fixes the issue. I am using page.js for routing and 3.6.0 breaks it. |
We'll need a repro to debug this. It doesn't have to be on codesandbox, it can be a git repo. Is this still present on the latest version? |
I cannot create gist now. The problem is still on Downgrading to |
I also caught this issue. Seems it somehow depends on #3058 |
After a small investigation, I'm sure it also depends on |
@Conduitry, I have a reproduction: https://codesandbox.io/s/vigilant-cache-4rtqy Open browser console, not the codesandbox's one. |
@frederikhors yup, same error. |
Reduced repro: A App.svelte <script>
let flag = false;
import Widget from './Widget.svelte';
</script>
<input type='checkbox' bind:checked={flag}>
<svelte:component this={flag && Widget}/> Widget.svelte {#await null}{/await} Toggling the checkbox on and off to display and destroy the child component throws this exception. |
prevent dynamic components being detached twice
Auto-closed by #3172, but re-opening because the repro at https://codesandbox.io/s/vigilant-cache-4rtqy is still buggy |
I take it back, it does appear to be fixed. |
I'm using it with
svelte-apollo
but I cannot create now reproduction on codesandbox.Maybe something related to
Object.destroy
from 3.6.0 (#3058)?The text was updated successfully, but these errors were encountered: