Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index of elements in each loop are not reactive inside if blocks #2569

Closed
pavish opened this issue Apr 26, 2019 · 3 comments · Fixed by #3443
Closed

Index of elements in each loop are not reactive inside if blocks #2569

pavish opened this issue Apr 26, 2019 · 3 comments · Fixed by #3443
Labels
bug

Comments

@pavish
Copy link

pavish commented Apr 26, 2019

REPL: https://svelte.dev/repl?version=3.0.1&gist=5b40d855b7b1627769fdcfff259a9fcb

Index specified on event handlers, inside if blocks within each blocks, do not get updated reactively. However, it does work if the index is displayed inside the if block.

In the above REPL, try removing f2 and then f3. f3 doesn't get removed, since the index remains the same.
@Conduitry Conduitry added the bug label May 1, 2019
@mblarsen
Copy link

mblarsen commented May 8, 2019

Maybe related to #2444?

@bwbroersma
Copy link
Contributor

bwbroersma commented Jun 2, 2019 •
edited
Loading

More minimal example of the bug, also only occurs with keyed each blocks.
See this REPL example based on @pk-iegaa sample

Rich-Harris added a commit that referenced this issue Aug 21, 2019
@Rich-Harris
update context if event handler uses index in keyed each block - fixes …
a77e454 
…#2569
@Rich-Harris Rich-Harris mentioned this issue Aug 21, 2019
Merged
Rich-Harris added a commit that referenced this issue Aug 22, 2019
@Rich-Harris
Merge pull request #3443 from sveltejs/gh-2569
143125e 
update context if event handler uses index in keyed each block
@Rich-Harris
Copy link
Member

Fixed in 3.9.1, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update context if event handler uses index in keyed each block sveltejs/svelte
5 participants
@mblarsen @Rich-Harris @bwbroersma @pavish @Conduitry