Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssr/register should sanitize filenames #1005

Closed
Rich-Harris opened this issue Dec 11, 2017 · 0 comments · Fixed by #1006
Closed

ssr/register should sanitize filenames #1005

Rich-Harris opened this issue Dec 11, 2017 · 0 comments · Fixed by #1006
Labels
bug

Comments

@Rich-Harris
Copy link
Member

This doesn't work:

require('svelte/ssr/register');
const Thing = require('./pages/:thing.html');

We get this error:

options.name must be a valid identifier
Rich-Harris added a commit that referenced this issue Dec 11, 2017
@Rich-Harris
sanitize filenames before SSRing - fixes #1005
42fb715
@Rich-Harris Rich-Harris mentioned this issue Dec 11, 2017
Merged
Rich-Harris added a commit that referenced this issue Dec 11, 2017
@Rich-Harris
sanitize filenames before SSRing - fixes #1005
774caf4
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this issue Dec 24, 2024
@github-actions @Rich-Harris
Sync svelte docs (sveltejs#1005)
5e1deac 
sync svelte docs

Co-authored-by: Rich-Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sanitize filenames before SSRing sveltejs/svelte
1 participant
@Rich-Harris