Merge pull request #3723 from sveltejs/always-set-attribute

don't cache attribute values
sveltejs · Oct 17, 2019 · ba72fd2 · ba72fd2
2 parents 99911c3 + 8aa9879
commit ba72fd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/compiler/compile/render_dom/wrappers/Element/Attribute.ts b/src/compiler/compile/render_dom/wrappers/Element/Attribute.ts
@@ -95,7 +95,7 @@ export default class AttributeWrapper {
 			const is_select_value_attribute =
 				name === 'value' && element.node.name === 'select';
 
-			const should_cache = (this.node.should_cache() || is_select_value_attribute);
+			const should_cache = is_select_value_attribute; // TODO is this necessary?
 
 			const last = should_cache && block.get_unique_name(
 				`${element.var.name}_${name.replace(/[^a-zA-Z_$]/g, '_')}_value`

diff --git a/test/js/samples/inline-style-unoptimized/expected.js b/test/js/samples/inline-style-unoptimized/expected.js
@@ -14,15 +14,14 @@ function create_fragment(ctx) {
 	let div0;
 	let t;
 	let div1;
-	let div1_style_value;
 
 	return {
 		c() {
 			div0 = element("div");
 			t = space();
 			div1 = element("div");
 			attr(div0, "style", ctx.style);
-			attr(div1, "style", div1_style_value = "" + (ctx.key + ": " + ctx.value));
+			attr(div1, "style", "" + (ctx.key + ": " + ctx.value));
 		},
 		m(target, anchor) {
 			insert(target, div0, anchor);
@@ -34,8 +33,8 @@ function create_fragment(ctx) {
 				attr(div0, "style", ctx.style);
 			}
 
-			if ((changed.key || changed.value) && div1_style_value !== (div1_style_value = "" + (ctx.key + ": " + ctx.value))) {
-				attr(div1, "style", div1_style_value);
+			if (changed.key || changed.value) {
+				attr(div1, "style", "" + (ctx.key + ": " + ctx.value));
 			}
 		},
 		i: noop,