Fixes keyed each blocks for outro

Fixes #1706
sveltejs · Sep 6, 2018 · 67d4d60 · 67d4d60
1 parent 2e4b65a
commit 67d4d60
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 1 deletion.
diff --git a/src/compile/nodes/EachBlock.ts b/src/compile/nodes/EachBlock.ts
@@ -331,7 +331,7 @@ export default class EachBlock extends Node {
 			${this.block.hasAnimation && `for (let #i = 0; #i < ${blocks}.length; #i += 1) ${blocks}[#i].a();`}
 		`);
 
-		if (this.compiler.options.nestedTransitions) {
+		if (this.block.hasOutros && this.compiler.options.nestedTransitions) {
 			const countdown = block.getUniqueName('countdown');
 			block.builders.outro.addBlock(deindent`
 				const ${countdown} = @callAfter(#outrocallback, ${blocks}.length);

diff --git a/test/runtime/samples/transition-js-nested-each-keyed-2/Widget.html b/test/runtime/samples/transition-js-nested-each-keyed-2/Widget.html
@@ -0,0 +1,3 @@
+{#each things as thing (thing)}
+  <div></div>
+{/each}
diff --git a/test/runtime/samples/transition-js-nested-each-keyed-2/_config.js b/test/runtime/samples/transition-js-nested-each-keyed-2/_config.js
@@ -0,0 +1,13 @@
+export default {
+	nestedTransitions: true,
+
+	data: {
+		x: true,
+		things: ['a', 'b']
+	},
+
+	test(assert, component, target, window, raf) {
+		component.set({ x: false });
+		assert.htmlEqual(target.innerHTML, '');
+	},
+};
diff --git a/test/runtime/samples/transition-js-nested-each-keyed-2/main.html b/test/runtime/samples/transition-js-nested-each-keyed-2/main.html
@@ -0,0 +1,9 @@
+{#if x}
+	<Widget :things/>
+{/if}
+
+<script>
+	export default {
+		components: { Widget: './Widget.html' }
+	};
+</script>