don't treat $$-names as stores during invalidation (#4453)

sveltejs · Feb 23, 2020 · 19f1c9c · 19f1c9c
1 parent 3bfa0e5
commit 19f1c9c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+* Do not treat modifications to `$$props` as updates to a store called `$props` ([#4368](https://github.com/sveltejs/svelte/issues/4368))
 * Deconflict `value` parameter name used in contextual bindings ([#4445](https://github.com/sveltejs/svelte/issues/4445))
 * Fix dev mode validation of `{#each}` blocks using strings ([#4450](https://github.com/sveltejs/svelte/issues/4450))
 

diff --git a/src/compiler/compile/render_dom/invalidate.ts b/src/compiler/compile/render_dom/invalidate.ts
@@ -43,7 +43,7 @@ export function invalidate(renderer: Renderer, scope: Scope, node: Node, names:
 		if (node.type === 'AssignmentExpression' && node.operator === '=' && nodes_match(node.left, node.right) && tail.length === 0) {
 			return get_invalidated(head, node);
 		} else {
-			const is_store_value = head.name[0] === '$';
+			const is_store_value = head.name[0] === '$' && head.name[1] !== '$';
 			const extra_args = tail.map(variable => get_invalidated(variable));
 
 			const pass_value = (