Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no outline in vscode #2353

Closed
easyfrog opened this issue Apr 26, 2024 · 1 comment
Closed

no outline in vscode #2353

easyfrog opened this issue Apr 26, 2024 · 1 comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@easyfrog
Copy link

Describe the bug

image No symbols found in document.

Reproduction

create a template svelte project`

Expected behaviour

has code outline.

System Info

  • OS: Mac os 13.6.6 (22G630)
  • IDE: vscode Version: 1.88.1

Which package is the issue about?

No response

Additional Information, eg. Screenshots

No response
@easyfrog easyfrog added the bug Something isn't working label Apr 26, 2024
@jasonlyu123
Copy link
Member

Reopen since it is indeed somewhat unreliable in VSCode when the file is first opened but usually reappears when the file is updated.

@jasonlyu123 jasonlyu123 reopened this May 28, 2024
@jasonlyu123 jasonlyu123 mentioned this issue May 29, 2024
Merged
dummdidumm pushed a commit that referenced this issue May 29, 2024
@jasonlyu123
fix: don't debounce document symbol request (#2382)
15a4aab 
#2353

The reason is that VSCode requested document symbols twice for the outline view and the sticky scroll. We cancelled one of them so the outline view shows "no symbols found in document 'A.svelte'". It seems the VSCode ts extension also caches the result from tsserver, mostly because it'll also be used in code lens. But the result is mostly fast enough. A 5000-line file takes like 100ms so we probably don't need it now. We can probably reconsider if #2378 lands and see if there is a large performance regression.
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dummdidumm @easyfrog @jasonlyu123