Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double check for 'keepFocus' and 'noScroll' in goto to allow for backcompatibity #7678

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Add double check for 'keepFocus' and 'noScroll' in goto to allow for backcompatibity #7678

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf68825
add double check for 'keepFocus' and 'noScroll' in goto to allow for …
paoloricciuti Nov 16, 2022
2f700a5
change line endings
paoloricciuti Nov 16, 2022
4c15bce
Fix precedence of operators
paoloricciuti Nov 16, 2022
94039bf
fix line endings again
paoloricciuti Nov 16, 2022
c51d45d
Change to add another parenthesis + fix line endings
paoloricciuti Nov 16, 2022
8293fae
This should fix identation and line endings
paoloricciuti Nov 16, 2022
1fdaccf
fix random formatting errors
paoloricciuti Nov 16, 2022
f53fe8d
Apply suggestions from code review
Rich-Harris Nov 16, 2022
691c9a9
Create hot-keys-lick.md
Rich-Harris Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/kit/src/runtime/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,13 +1202,13 @@ export function create_client({ target, base, trailing_slash }) {

goto: (href, opts = {}) => {
// TODO remove for 1.0
if ('keepfocus' in opts) {
if (!('keepFocus' in opts) && ('keepfocus' in opts)) {
throw new Error(
'`keepfocus` has been renamed to `keepFocus` (note the difference in casing)'
);
}

if ('noscroll' in opts) {
if (!('noScroll' in opts) && ('noscroll' in opts)) {
throw new Error(
'`noscroll` has been renamed to `noScroll` (note the difference in casing)'
);
Expand Down