-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] change Vite's output directory from _app to client #5620
Conversation
🦋 Changeset detectedLatest commit: 5eddc20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This introduces a very minor bug — workers are no longer written to Not enough to prevent merging this PR, but worth noting nonetheless |
This fixes an issue that @userquin ran into trying to make
vite-plugin-pwa
work with SvelteKit. He was using Vite/Rollup'semit
to output a service worker manifest and expecting it to be served from the root directory, but it was ending up under_app
._app
is arguable only for stuff generated by SvelteKit though. I could imagine lots of other things like arobots.txt
or something you might want to generate with a Vite plugin that need to go in a certain location and are impossible to put there today.I also think the code ends up being a little nicer this was as we don't end up having to specify the app dir in quite as many places
I'm splitting this out from #5601 as that PR was becoming too unwieldy