Generated types invalid for routes with matched parameter

[istarkov]

Generated types invalid for routes with matched parameter

Ref #4327 #4361

Bug description

The automatically generated types for routes with matched parameters are invalid.
i.e. route like /[lang=is_lang]/[name] will generate following

export type RequestHandler<Output extends ResponseBody = ResponseBody> = GenericRequestHandler<{ lang=is_lang: string; name: string }, Output>;

After this PR

export type RequestHandler<Output extends ResponseBody = ResponseBody> = GenericRequestHandler<{ lang: string; name: string }, Output>;

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

🦋 Changeset detected

Latest commit: bccaa11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[benmccann]

Cool. Thanks for the fix. Perhaps it would be good to expose extract_params and add a unit test for it

[istarkov]

Based on this comment #4361 (comment)

We could get the canonical list of params from the manifest data for routes

Seems like implementation will be changed seriously some day, as extracting params using different code doesn't look good.

This is just a quick fix allowing to use modern features.

PS: For me types generated for components like __layout should be changed too, i.e params for __layout should be Record<string, string> instead of {}

[Rich-Harris]

Thank you. Since write_types was written, a parse_route_id function was added which we can use instead — closing this in favour of #4472