Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode URI when previewing prerendered pages #12874

Merged
merged 8 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-turkeys-jump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: decode non-latin characters when previewing prerendered pages
11 changes: 8 additions & 3 deletions packages/kit/src/exports/vite/preview/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,14 @@ export async function preview(vite, vite_config, svelte_config) {

const { pathname, search } = new URL(/** @type {string} */ (req.url), 'http://dummy');

let filename = normalizePath(
join(svelte_config.kit.outDir, 'output/prerendered/pages' + pathname)
);
let filename = normalizePath(join(svelte_config.kit.outDir, 'output/prerendered/pages' + pathname));

try {
filename = decodeURI(filename)
} catch {
// malformed URI
}

let prerendered = is_file(filename);

if (!prerendered) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const prerender = true;
5 changes: 5 additions & 0 deletions packages/kit/test/apps/basics/test/server.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,11 @@ test.describe('Miscellaneous', () => {
expect(response.status()).toBe(200);
expect(await response.text()).toBe('foo');
});

test('serves prerendered non-latin pages', async ({ request }) => {
const response = await request.get('/prerendering/中文');
expect(response.status()).toBe(200);
});
});

test.describe('reroute', () => {
Expand Down
Loading