-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct type for '*?enhanced' imports #12224
Conversation
🦋 Changeset detectedLatest commit: 9e5f66f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1,11 +1,14 @@ | |||
import 'svelte/elements'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not much of a typescript expert. why was this changed from import { HTMLImgAttributes } from 'svelte/elements';
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since HTMLImgAttributes
is not used anywhere else outside the declare block, typescript complains that it is an unused import. (similar to microsoft/TypeScript#45061)
So one way to solve this is to import the module itself. Other option is to declare a type alias outside the declare
block. Third option is to use the dynamic type import syntax.
this looks broken e-e |
How so? |
@itsmikesharescode This should be fixed by #12363. Cc: @benmccann |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits
Currently the type of an enhanced import is
string
, which is wrong. You can easily verify by logging the imported value. The correct type isPicture
.