Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct type for '*?enhanced' imports #12224

Merged
merged 2 commits into from
May 21, 2024

Conversation

ranjan-purbey
Copy link
Contributor


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Currently the type of an enhanced import is string, which is wrong. You can easily verify by logging the imported value. The correct type is Picture.

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 9e5f66f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1,11 +1,14 @@
import 'svelte/elements';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much of a typescript expert. why was this changed from import { HTMLImgAttributes } from 'svelte/elements';?

Copy link
Contributor Author

@ranjan-purbey ranjan-purbey May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since HTMLImgAttributes is not used anywhere else outside the declare block, typescript complains that it is an unused import. (similar to microsoft/TypeScript#45061)

So one way to solve this is to import the module itself. Other option is to declare a type alias outside the declare block. Third option is to use the dynamic type import syntax.

@itsmikesharescode
Copy link

this looks broken e-e

@benmccann
Copy link
Member

How so?

@BastiDood
Copy link
Contributor

BastiDood commented Jun 17, 2024

this looks broken e-e

@itsmikesharescode This should be fixed by #12363. Cc: @benmccann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants