-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support shorthand attribute syntax on enhanced-img #11884
fix: support shorthand attribute syntax on enhanced-img #11884
Conversation
🦋 Changeset detectedLatest commit: e648afe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
<enhanced:img>
<enhanced:img>
@@ -42,3 +42,7 @@ | |||
<source srcset="./foo.avif 500v ./bar.avif 100v" /> | |||
<source srcset="./foo.avif, ./bar.avif 1v" /> | |||
</picture> | |||
|
|||
{#each images as src} | |||
<enhanced:img {src} alt="opt-in test" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a small change to change this from "opt-in test" to "attribute shorthand test"
Thank you so much for this! Sorry it took me awhile to get to reviewing it. I'll merge it in just a minute when the CI turns green |
This PR adds support for the Attribute shorthand syntax on
<enhanced:img
components.It is now possible to write the following code:
Previously this would error
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits