Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: LIBRARY: DnD: Survey-Elements #9542

Merged
merged 3 commits into from
Mar 10, 2025
Merged

PR: LIBRARY: DnD: Survey-Elements #9542

merged 3 commits into from
Mar 10, 2025

Conversation

dmitry-kurmanov
Copy link
Member

@dmitry-kurmanov dmitry-kurmanov self-assigned this Mar 2, 2025
@dmitry-kurmanov dmitry-kurmanov added bug enhancement user issue An issue or bug reported by users labels Mar 2, 2025
@dmitry-kurmanov dmitry-kurmanov changed the title PR: LIBRARY: DnD: Survey-Elements: Refactoring PR: LIBRARY: DnD: Survey-Elements Mar 6, 2025
@dmitry-kurmanov dmitry-kurmanov marked this pull request as ready for review March 7, 2025 14:11
@dmitry-kurmanov dmitry-kurmanov requested a review from tsv2013 March 7, 2025 14:12
tsv2013
tsv2013 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@tsv2013 tsv2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to remove comment
// creator dragdrop usage
public dragDropFindRow(findElement: ISurveyElement): QuestionRowModel {

and rename method to findRowByElement{element: ISurveyElement}
or remove it if it already exists

@dmitry-kurmanov dmitry-kurmanov merged commit dad9f36 into master Mar 10, 2025
5 checks passed
@dmitry-kurmanov dmitry-kurmanov deleted the bug/private-475-dnd-survey-elements branch March 10, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsv2013 tsv2013 tsv2013 approved these changes

Assignees

@dmitry-kurmanov dmitry-kurmanov

Labels
bug enhancement user issue An issue or bug reported by users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitry-kurmanov @tsv2013