Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Dynamic Matrix: The "Show Details" and "Hide Details" button captions are not updated according to the current state of a detail section #9410

Closed
nikhilpatel7 opened this issue Feb 5, 2025 · 8 comments · Fixed by #9423
Assignees
Labels
bug user issue An issue or bug reported by users

Comments

@nikhilpatel7
Copy link

Describe the bug
A clear and concise description of what the bug is.
In Dynamic matrix when we have expandable rows with details and if we have auto collapse when another row is expanded,
it doesn't change the label for auto collapsing row.

Here is the screenshot how my expanded details look like when expanded. which is correct

Image

Now if I expand another row which I added previously, above row will be collapsed which is correct/expected behavior, However the label is not updated correctly as below.

Image

Image

Above highlighted labels are wrong. It works fine in web version but for mobile app/view it doesn't update the label correctly.

Please complete the following information:

  • Browser: [chrome,]
  • Browser version: [Version 132.0.6834.160 (Official Build) (64-bit)]
  • JS framework/library: [issue can re-produced on survey designer on "https://surveyjs.io/" itself]
  • SurveyJS version: ["v1.12.20"]
  • Device: [any mobile device/mobie view]
@JaneSjs JaneSjs self-assigned this Feb 5, 2025
@JaneSjs
Copy link
Contributor

JaneSjs commented Feb 5, 2025

Hi @nikhilpatel7,
I tested the Matrix Rows with Expandable Details Sections demo and confirmed that the Show Details / Hide Details button caption is updated correctly. Please check the following screencast:

document_5269312633193915169.mp4

Would you please clarify how to reproduce the issue? Please share a problematic survey JSON and specify which SurveyJS package you're using.

Thank you

@nikhilpatel7
Copy link
Author

nikhilpatel7 commented Feb 5, 2025

Hi @JaneSjs ,
Sorry I didn't mentioned exact steps. I am attaching video for the reference.

The issue is mainly when we have auto collapsible rows. So when it is expanded with "Hide Details" and we expand another row then already expanded row gets collapsed and label is not updated.

Survey.Js.-.Showhide.button.label.issue.MP4

@JaneSjs
Copy link
Contributor

JaneSjs commented Feb 5, 2025

Hello,
I would appreciate it if you share a survey JSON definition for research.

Thank you

@nikhilpatel7
Copy link
Author

Hi @JaneSjs ,

Here is the requested JSON.

Demo survey json.json

@JaneSjs JaneSjs added bug user issue An issue or bug reported by users and removed question need more info labels Feb 6, 2025
@JaneSjs JaneSjs removed their assignment Feb 6, 2025
@JaneSjs
Copy link
Contributor

JaneSjs commented Feb 6, 2025

Thank you for the update. I reproduced it on my end using the following demo: View Plunker.

We'll research this issue and update you shortly.

novikov82 added a commit that referenced this issue Feb 7, 2025
novikov82 added a commit that referenced this issue Feb 7, 2025
novikov82 added a commit that referenced this issue Feb 9, 2025
tsv2013 pushed a commit that referenced this issue Feb 10, 2025
…s incorrect label issue (#9423)

* #9410 Dynamic matrix - In mobile view Show Detail/Hide Details buttons incorrect label issue
Fixes #9410

* resize before test #9410

* fixed test Dynamic matrix - In mobile view Show Detail/Hide Details buttons incorrect label issue #9410
novikov82 added a commit that referenced this issue Feb 10, 2025
novikov82 added a commit that referenced this issue Feb 10, 2025
…ons incorrect label issue

Fixes #9410

* resize before test #9410

* fixed test Dynamic matrix - In mobile view Show Detail/Hide Details buttons incorrect label issue #9410
tsv2013 pushed a commit that referenced this issue Feb 10, 2025
* Mobile matrix footer - addRowLocation - top #9425
Fixed #9425

* #9410 update screenshots
novikov82 added a commit that referenced this issue Feb 10, 2025
* Mobile matrix footer - addRowLocation - top #9425
Fixed #9425

* #9410 update screenshots
@RomanTsukanov RomanTsukanov changed the title Dynamic matrix - In mobile view Show Detail/Hide Details buttons incorrect label issue [Mobile] Dynamic Matrix: The "Show Details" and "Hide Details" button captions are not updated according to the current state of a detail section Feb 11, 2025
@nikhilpatel7
Copy link
Author

@JaneSjs Do you know under which version this was fixed?
Because this is still reproducible in v1.12.23.

@JaneSjs
Copy link
Contributor

JaneSjs commented Feb 18, 2025

Hi @nikhilpatel7,
I tested v1.12.23 on my end (View Demo) and confirmed that the button label is updated as needed.

2025-02-18_10-49-19.mp4

Please test this demo on your end. Let me know how it goes.

@JaneSjs JaneSjs reopened this Feb 18, 2025
@JaneSjs JaneSjs assigned JaneSjs and unassigned novikov82 Feb 18, 2025
@nikhilpatel7
Copy link
Author

Hi @JaneSjs ,
Sorry it looks like it was caching issue probably. It is working fine. Thanks for sharing the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user issue An issue or bug reported by users
Projects
None yet
3 participants