-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve text direction detection by adding the lang
and dir
attributes
#8335
Comments
lang
and dir
attributes
tsv2013
pushed a commit
that referenced
this issue
Jun 26, 2024
…dir attributes - try to fix maskup tests
tsv2013
pushed a commit
that referenced
this issue
Jun 26, 2024
…dir attributes - try to fix markup tests
OlgaLarina
added a commit
that referenced
this issue
Jun 26, 2024
Implemented #8335 - Improve text direction detection by adding lang and dir attributes
lang
and dir
attributeslang
and dir
attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are you requesting a feature, reporting a bug or asking a question?
Bug / feature
What is the current behavior?
SurveyJS doesn't support RTL languages automatically.
What is the expected behavior?
It should be supported automatically (and dynamically)
How would you reproduce the current behavior (if this is a bug)?
Solution
I realize this is quite a complex topic. I've been researching solutions for a bit.
First of all we need to note a few things:
lang
attribute on the proper element.If we ignore 2 for now, we could:
lang={survey.language}
to the survey root element dynamically. (So it updates when survey language changes)flex:row
, which is what we need for navigation buttons.My working code to fix this looks like this:
Note that
rootElement$
andlocale$
are observables linked to the survey.The text was updated successfully, but these errors were encountered: