275: Change password and email #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
approved these changes
Aug 14, 2021
|
Whilst this is OK, please only merge it when the associated core and db plugins PRs have also been approved. |
rishabhpoddar
pushed a commit
that referenced
this pull request
Aug 21, 2021
* Add update users email SQL method * Update changelog * adds duplicate email exception Co-authored-by: Rishabh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This adds an interface method to SQL Storage to update an email within a transaction. This enforces the corresponding core logic to reuse existing update password method.
Related issues
Checklist for important updates
[ ] Changes to the version if neededInbuild.gradlegit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR
None.