Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LinkedIn OAuth #751 #754

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: LinkedIn OAuth #751 #754

merged 2 commits into from
Dec 5, 2023

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Dec 5, 2023

Summary of change

This PR updates the LinkedIn OAuth implementation as per the recent changes.

Related issues

Test Plan

Tested manually.

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Item1
  • Item2

@anku255 anku255 requested a review from rishabhpoddar December 5, 2023 12:12
@rishabhpoddar rishabhpoddar merged commit cbc4d89 into 16.6 Dec 5, 2023
@rishabhpoddar rishabhpoddar deleted the fix/linkedin-oauth branch December 5, 2023 12:18
@anku255 anku255 mentioned this pull request Dec 5, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants