-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating the recipe module manager skeleton and make that structure work with sessions #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… puts session into a recipe based folder
…ing super in arrow functions
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Changes:
rId
. This way, if the querier throws an error, the recipe module manager can identity which recipe it originated from. This has a side effect that the if the recipeModuleManager itself uses the querier, then it must give its ownrId
as "" (But this doesn't happen anywhere as of yet).AuthError
toSessionError
isErrorFromAuth
toisErrorFromThisRecipe
SuperTokensError
which contains:type
: Used to identify the type of an error within a recipemessage
: A user-friendly message describing the error.payload
: Can be any payload specific to that error typerId
: The recipe ID that threw this error. If the error originates from the recipeModuleManager itself, this will be""
app.use(supertokens.init({...}))
has changed toapp.use(supertokens.middleware())
. Theinit
function for session no longer returns a middleware.setOptionsAPIHeader
functionsupertokens.init
:hosts
andapiKey
are insidesupertokens
objecthosts
has been renamed toconnectionURI
connectionURI
is now compulsory to giveconfig
in theinit
function as per Implement a recipeModule manager #16accessTokenPath
getCORSAllowedHeaders
togetAllCORSHeaders
session.middleware
tosession.verifySession
setRelevantHeadersForOptionsAPI
Migration:
init
functionaccessTokenPath
getCORSAllowedHeaders
togetAllCORSHeaders
session.middleware
tosession.verifySession
setRelevantHeadersForOptionsAPI