Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to config #24

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Changes to config #24

merged 3 commits into from
Oct 21, 2020

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Oct 21, 2020 •
edited
Loading

Related issues:

Changes:

  • Normalising of all user input
  • Removed refreshTokenPath and replaced it with apiBasePath
  • Refactor of init code
  • Added tests for checking of init and user configuration

Migration:

  • Remove refreshTokenPath and use apiBasePath instead. The refresh API will always be apiBasePath + "/session/refresh". This will require a change in the init config and the refresh API

Docs change - commit hash c5dbab42672457b5d41b2ed63a486b3ba666e6bf in main-website repo

This was referenced Oct 21, 2020
Open
Open
@rishabhpoddar rishabhpoddar merged commit c8813f4 into 3.0 Oct 21, 2020
@rishabhpoddar rishabhpoddar deleted the config-change branch October 21, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rishabhpoddar