Refactor all notifications from extensions and UI toggling such that … #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it works and saves to DB.
tomaskikutis
reviewed
Aug 6, 2024
| @@ -48,8 +48,7 @@ const extension: IExtension = { | |||
| }, | |||
| notifications: { | |||
| 'item:marked': { | |||
| type: 'desktop', | |||
| label: gettext('open item'), | |||
| name: gettext('Mark for User'), | |||
There was a problem hiding this comment.
does this unified notification notify both of marking and unmarking? Check with if API exposes this information and coordinate with Petr if not
There was a problem hiding this comment.
Yes, works for marking and unmarking. Only difference between the two previously was the body message, handler was indeed the same one.
tomaskikutis
reviewed
Aug 7, 2024
tomaskikutis
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDBELGA-818
trueeven if a user doesn't have them saved in preferences