fix media metadata editor changes not being saved #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was calling authoring editor instances to generate html which then overwrote any changes done in modal. SDESK-7304
petrjasek
force-pushed
the
fix-image-metadata-editor
branch
from
2ad6639 to
03f7abe
Compare
scripts/apps/authoring/authoring/directives/AuthoringDirective.ts
Outdated
Show resolved
Hide resolved
scripts/apps/authoring/authoring/directives/AuthoringDirective.ts
Outdated
Show resolved
Hide resolved
scripts/apps/authoring/authoring/directives/ArticleEditDirective.ts
Outdated
Show resolved
Hide resolved
tomaskikutis
approved these changes
Jul 18, 2024
|
|
||
| async saveMetadata(): Promise<void> { | ||
| await this.page.locator(s('media-editor', 'apply-metadata-button')).click(); | ||
| await this.page.locator(s('change-image', 'done')).click(); |
There was a problem hiding this comment.
is change-image image selector still inside "media-editor"? If it is, it'd be good to scope it:
await this.page.locator(s('media-editor', 'change-image', 'done')).click();
The reason being not uniqueness, but documentation - ability to quickly understand the hierarchy without having to look it up inside dev tools.
There was a problem hiding this comment.
those are on the same level
petrjasek
added a commit
to petrjasek/superdesk-client-core
that referenced
this pull request
Jul 22, 2024
* fix media metadata editor changes not being saved it was calling authoring editor instances to generate html which then overwrote any changes done in modal. SDESK-7304 * trigger actions * add test from authoring to modal * trigger autosave when opening modal * only trigger autosave if dirty * fix protractor * fix failing protractor tests * handle feedback * docs * create picture authoring object * tweak test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was calling authoring editor instances to generate html which then overwrote any changes done in modal.
SDESK-7304