Fix saving when item closed with changes #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomaskikutis I'm not sure why the changes for |
|
Just double checked, you reverted it in |
|
I've reverted my changes, leaving your latest in the AuthoringTopbarDirective. The fix is different, and looks better. It looks like you've achieved what I wanted to do in the first place. I simply made the call to compute html before passing scope to other functions. |
tomaskikutis
approved these changes
Jun 11, 2024
petrjasek
pushed a commit
that referenced
this pull request
Jun 12, 2024
dzonidoo
pushed a commit
to dzonidoo/superdesk-client-core
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7295
Tested on authoring react and angular.