Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom blocks tab #4519

Closed
wants to merge 24 commits into from
Closed

Custom blocks tab #4519

wants to merge 24 commits into from

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented May 14, 2024 •
edited
Loading

BOR-12
BOR-5
BOR-6
BOR-7

@thecalcc thecalcc requested a review from tomaskikutis May 14, 2024 12:14
@thecalcc
Copy link
Contributor Author

thecalcc commented May 14, 2024 •
edited
Loading

Demo:

Screen.Recording.2024-05-14.at.15.16.32.mov

@thecalcc
Copy link
Contributor Author

Sample config:

my custom editor block.json

tomaskikutis
tomaskikutis reviewed May 14, 2024
View reviewed changes
scripts/apps/workspace/content/views/FormattingOptionsMultiSelect.tsx Outdated Show resolved Hide resolved
scripts/core/editor3/directive.tsx Outdated Show resolved Hide resolved
scripts/core/editor3/directive.tsx Outdated Show resolved Hide resolved
scripts/core/editor3/directive.tsx Outdated Show resolved Hide resolved
scripts/core/editor3/directive.tsx Outdated Show resolved Hide resolved
scripts/apps/vocabularies/controllers/VocabularyEditController.tsx Outdated Show resolved Hide resolved
scripts/apps/vocabularies/controllers/VocabularyEditController.tsx Outdated Show resolved Hide resolved
scripts/apps/vocabularies/controllers/VocabularyEditController.tsx Outdated Show resolved Hide resolved
scripts/apps/vocabularies/controllers/VocabularyEditController.tsx Show resolved Hide resolved
scripts/apps/vocabularies/controllers/VocabularyEditController.tsx Outdated Show resolved Hide resolved
@thecalcc thecalcc requested a review from tomaskikutis May 17, 2024 09:13
tomaskikutis
tomaskikutis approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with code. The only thing left is to fix the tests which I'll do in my branch.

@tomaskikutis tomaskikutis mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @tomaskikutis