Fix for editor3 performance improvements #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
reviewed
Apr 18, 2024
| return $q((resolve) => { | ||
| // delay required for loading state to render | ||
| // before possibly long operation (with huge articles) | ||
| setTimeout(() => { |
There was a problem hiding this comment.
if you use $timeout protractor will know it should wait for it, not sure if that's causing any issues but just in case
they were passing for at least 6 months while the feature was broken
petrjasek
approved these changes
Apr 26, 2024
item appearing in publish queue after publishing meant to replace mysteriously failing protractor test
petrjasek
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7248