Search field improvements #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaskikutis
reviewed
Feb 6, 2023
| <div className="search-handler" role="search"> | ||
| <label | ||
| className="trigger-icon" | ||
| htmlFor="vocabulary-search" | ||
| aria-label={gettext('Toggle search')} | ||
| onClick={() => { | ||
| this.setState({searchExtended: !this.state.searchExtended}); |
There was a problem hiding this comment.
if change removes usages of a variable, variable declaration has to be removed too - in this case in type definition and constructor. see searchExtended
| @@ -350,7 +350,10 @@ export class ArticlesListByQueryWithFilters extends React.PureComponent<IProps, | |||
| </h3> | |||
| <Badge type="default">{itemsCount}</Badge> | |||
| </div> | |||
| <div style={{marginLeft: 10, flexGrow: 1}}> | |||
| <div | |||
| className="sd-display--flex sd-flex--grow | |||
There was a problem hiding this comment.
double quotes don't support being used across multiple lines.
instead use:
<div
className={classnames(
'class1',
'class2',
'class3',
)}
/>
| <label | ||
| htmlFor={_uniqueId} | ||
| className="trigger-icon" | ||
| onClick={this.toggleSearchBar} |
There was a problem hiding this comment.
if change removes usages of a variable, variable declaration has to be removed too
styles/sass/sf-additional.scss
Outdated
| } | ||
|
|
||
| // Padding | ||
| .sd-padding-s { |
There was a problem hiding this comment.
it'd be clearer to use padding-start instead of padding-s. padding-s might as well be understood as "padding small". I'd use the full word for e too.
tomaskikutis
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.