Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dateline field implemented in React #4190

Merged

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Jan 23, 2023

TODO: Implement patching of object fields

@thecalcc thecalcc requested a review from tomaskikutis January 26, 2023 11:18
@tomaskikutis
Copy link
Member

create article with that field in angular then modify it in react and go back to angular and

Dateline field PR
IDatelineValueOperational - add comment for day field format or if it's week days type them like that

PlacesService - (x) => geoNameToCity(x)

data-layer.ts - Object patching is overriding objects that's why we need to add the full object to the diff for fields that are of object type

editor.tsx - add abort controller and function to cancel the request in searchOptions function

@thecalcc
Copy link
Contributor Author

thecalcc commented Feb 20, 2023

IDatelineValueOperational - add comment for day field format or if it's week days type them like that

We never actually fill that field so I will remove it.

@thecalcc
Copy link
Contributor Author

Use abort controller.

@thecalcc thecalcc merged commit c84be09 into superdesk:authoring-react-post-broadcasting Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants