-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): add Clerk Wasm FDW #404
Conversation
CI failed due to pgcentralfoundation/pgrx#1966 |
Need to wait for #409 to be merged first to fix CI issue. |
Hello - thank you for putting this together! I read through the PR and we're going to suggest a few adjustments (change table name to Would you prefer we fork this branch or another process? Since we'd plan on changing the table names, everything we suggest will be backward compatible, so there's no need to block on us if you want to move forward. Thanks again! |
Thanks for your suggestions @colinclerk. We already suggested using dedicated schema For cheery picking column set, we definitely can pick some more properties if you think they are more important, but that only works for 1-to-1 properties. For some properties like email addresses, they are 1-to-many relationship with the object, and currently the foreign table can only return 1 row for 1 object, so we'd better to keep those properties in json column and let user use subquery or view to extract it out. You can directly push on this branch or create another fork, we'd like to see more feedbacks from you for this fdw and thanks again! |
What kind of change does this PR introduce?
This PR is to add a new Clerk Wasm foreign data wrapper.
What is the current behavior?
N/A
What is the new behavior?
N/A
Additional context
N/A